fix(compactor): fix fd leak after failed index load #19408
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In case a compaction fails due to a partially failed index fetching or loading, the successfully opened
Index
objects are not closed. The index*TSDBFile
opens mmapped view to the file, which increases the reference count to the file description. This reference is never released.This causes a file description leak.
This PR fixes the logic such that in the case of an partial index load failure, we Close the indices we succeeded to load.
Which issue(s) this PR fixes:
Looks similar to #12105 but may not necessarily be the same issue.
Special notes for your reviewer:
Note that the file descriptor is not leaked. The file descriptor to the file is owned by
os.File
of thefileutil.MmapFile
which is eventually closed by GC finalizer. But the file description to which the descriptor referred to is leaked (struct file
in linux).Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
deprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR